Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process00{1,2} tests: just assume ls is in the PATH on non-Windows systems #133

Merged
merged 1 commit into from
Jun 13, 2018

Conversation

alpmestan
Copy link
Contributor

This should work on all the systems I've ever laid my hands on (not many, admittedly) and of particular interest to me and several other GHC/core libraries contributors who run GHC's testsuite, with this patch those tests now pass on NixOS.

$ TEST="process001 process002" ./validate --fast --testsuite-only
[...]
==== STAGE 2 TESTS ==== 

SUMMARY for test run started at Tue Jun 12 15:51:02 2018 CEST
 0:00:01 spent to go through
       2 total tests, which gave rise to
      14 test cases, of which
      12 were skipped

       0 had missing libraries
       2 expected passes
       0 expected failures

       0 caused framework failures
       0 caused framework warnings
       0 unexpected passes
       0 unexpected failures
       0 unexpected stat failures

There, ls is not under /bin but somewhere in the nix store and brought into the PATH through symlinks in a "current environment" directory which itself is in the PATH.

@snoyberg
Copy link
Collaborator

@bgamari Since this affects the GHC test suite and not the process test suite, would you mind giving it a review? I don't see any issues myself, but I'm not very familiar with GHC's test suite setup.

@Mistuke The changes here touch on Windows-specific code, but seem to leave the Windows code path identical to what it was before, so I don't believe it should affect Win32 at all.

@int-index
Copy link
Contributor

@snoyberg Ben has expressed his approval of this change here: alpmestan/ghc.nix#10 (comment)

@snoyberg snoyberg merged commit 2c517dd into haskell:master Jun 13, 2018
@snoyberg
Copy link
Collaborator

Thanks @int-index

@alpmestan alpmestan deleted the alp/ls-tests branch June 13, 2018 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants