add stictness to vector updating in histogram_ to avoid space leak #114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Kernel Density Estimation algorithm, we detected a space leak that causes a stack overflow for large inputs. After some profiling, this was discovered to be due to a lack of strictness in the histogram_ function when it updates an element in a vector.
This change simply uses a bang pattern to introduce strictness in that function as necessary to remove the space leak, and enable us to run the Kernel Density Estimation functions in constant space.