-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compute quarter boundaries based on a given day/quarter #179
Comments
This or something like it makes sense. |
Number of ways we could go with this. For example, we currently have:
So we could do this:
Alternatively (or additionally), we could do:
|
Great, thank you for the ideas, I'm going to try the first approach |
[#179] Add HasDays type class and instances
Going to do |
OK this is done now. |
@AshleyYakeley thank you for all the follow-up work renaming the type class and moving class instances close to the type definitions, I was in doubt of following that path or creating a separate Instances module like |
[#179] Add property and unit tests for DayPeriod functions
The addition of a module to handler quarters is very useful. As a Rubyist (and Haskeller) I like to come back to Ruby in search of features to implement in Haskell and I found the following one pretty useful:
An equivalent Haskell version would look something similar to:
I understand this is a core library and this feature might get rejected, but dealing with quarters seems like a pretty common use case. I'll be more than happy to submit a PR if this feature gets approved.
Reference
The text was updated successfully, but these errors were encountered: