Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure is broken #52

Closed
pgj opened this issue Nov 27, 2015 · 1 comment
Closed

configure is broken #52

pgj opened this issue Nov 27, 2015 · 1 comment

Comments

@pgj
Copy link

pgj commented Nov 27, 2015

Commit b06446edd4753f964a46d27ddae864fad97adc13 has changed the semantics of configure that it now fails to properly detect if fdatasync(2) is available on the given platform. For more details, please see ticket #11137 of GHC.
pgj referenced this issue Nov 27, 2015
@argiopetech
Adds a more comprehensive check for fdatasync
b06446e 
Some versions of OS X have fdatasync in the headers but don't include implementations in the standard library. This leads to a compile failure in configure.ac when using AC_CHECK_FUNCS.

This change explicitly attempts to compile a file containing a call to fdatasync and properly sets the AC_CHECK_FUNCS flags depending on the result of compilation.
@thomie thomie mentioned this issue Dec 10, 2015
Closed
hvr added a commit that referenced this issue Dec 16, 2015
@hvr
Improve detection of fdatasync(2)
5d5b747 
This attempts a simpler and hopefully more robust test for `fdatasync(2)`

See 94d8824 / #42 for the previous attempt.

This hopefully addresses #52 in a better way than #53
@pgj
Copy link
Author

pgj commented Dec 23, 2015

I can confirm that commit 5d5b74716b696b0f22c37a88ccc5c114b13f0398 works for me.

@pgj pgj closed this as completed Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use -Werror=implicit-function-declaration when checking for fdatasync
1 participant
@pgj