Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use -Werror=implicit-function-declaration when checking for fdatasync #53

Closed
wants to merge 1 commit into from
Closed

Use -Werror=implicit-function-declaration when checking for fdatasync #53

wants to merge 1 commit into from

Conversation

thomie
Copy link
Contributor

@thomie thomie commented Dec 10, 2015

This fixes #52.

Testcase:

  • in configure.ac, change fdatasync(4) to foo(4)
  • autoconf && ./configure
  • notice that configure now reports: checking for fdatasync... no.

@thomie
Use -Werror=implicit-function-declaration when checking for fdatasync
b774ee7 
This fixes #52.

Testcase:
  * in configure.ac, change `fdatasync(4)` to `foo(4)`
  * autoconf && ./configure
  * notice that configure now reports: `checking for fdatasync... no`.
@hvr
Copy link
Member

hvr commented Dec 12, 2015

  1. Tbh, I really dislike to abuse -Werror=implicit-function-declaration for that
  2. There's this instead for testing prototypes: https://www.gnu.org/software/autoconf/manual/autoconf-2.65/html_node/Generic-Declarations.html
  3. We should probably rewrite the fdatasync-autoconf test in terms of AC_CHECK_FUNCS and AC_CHECKS_DECLS

@thomie
Copy link
Contributor Author

thomie commented Dec 13, 2015

Agreed.

@thomie thomie closed this Dec 13, 2015
hvr added a commit that referenced this pull request Dec 16, 2015
@hvr
Improve detection of fdatasync(2)
5d5b747 
This attempts a simpler and hopefully more robust test for `fdatasync(2)`

See 94d8824 / #42 for the previous attempt.

This hopefully addresses #52 in a better way than #53
@thomie thomie deleted the fdatasync branch February 16, 2016 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

configure is broken
2 participants
@thomie @hvr