fix long standing fusion bug in enumFromTo_double and improve baseline testing tooling #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanks to Amos Robinson for helping figure out the correct implementation
… quickecheck >= 2.7 series, and can be invoked in every travisCI run
|
pinging @dolio |
Merged
|
@hvr just different branches, they should be the same, I just couldn't figure out how to use the same commit in both PRs. though if you were to pick only one, I like this one more because i remembered to thank amos for helping me |
dolio
added a commit
that referenced
this pull request
Jun 27, 2014
fix long standing fusion bug in enumFromTo_double and improve baseline testing tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
special thanks to @amosr for helping figure out the correct fix
I moved the tests into the main cabal, so they can be invoked by cabal test, and updated them to use quickcheck 2.7
also cabal test (and thence the test suite ) will now be invoked by by travis ci on every one. (doing the same for cabal bench is left for some other time)