-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small tool for generating the scaffolding of a new error message. #408
Small tool for generating the scaffolding of a new error message. #408
Conversation
This is a good idea! It'll simplify a lot of things. We have a shell script somewhere in the repo that does something similar, but this one seems much easier to use. |
Replace it with haskellfoundation#408 script when possible.
d18eb8a
to
9e9b9e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few fairly small comments.
I think that this is also much more useful if it includes easy instructions for running it.
message-index/helper-tool.hs
Outdated
let toplvl_index = | ||
unlines | ||
[ "---", | ||
"title: " <> title tmpl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have to worry about any of the complicated YAML coercion rules here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about what YAML accepts or doesn't accept, and how to test this in the script without writing complex validation logic 🤷♂️ I hope that incorrect YAML will be caught by the CI when trying to build the site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that incorrect YAML is more likely to create icky output HTML than it is to actually cause an error message, unfortunately. But we can always add quotes around things if we need to afterwards.
Thanks for this, I think it really lowers the barriers to contribution! |
Sorry for the slow response here - I'm totally sunk organizing the Rapperswil event right now. I'll get to this as soon as I can! |
Maybe the name of the script can be something more descriptive than |
I would prefer a more descriptive name like @ulysses4ever, but I don't think it's a blocker. Better to get this in here prior to Zurihac! |
Renamed it to |
🎆 |
Replace it with haskellfoundation#408 script when possible.
Small tool for creating new error messages more easily.