Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Adds migration to official MariaDB add-on #77

Merged
merged 2 commits into from Feb 29, 2020

Conversation

frenck
Copy link
Member

@frenck frenck commented Feb 29, 2020

Proposed Changes

This migrates the add-on to use the official MariaDB add-on.

The idea is that it looks for an existing local MySQL data directory, if that exists:

  • Start up local mariadb
  • Do regular fixes and ensurances
  • dump the nginxproxymanager database to the backup folder (so a user could access it)
  • shut down the local mariab db server
  • Import the export/backup into the core mariadb add-on

@addons-assistant
Copy link

💖 Thanks for opening this pull request! 💖 If your PR gets accepted and merged in, we will invite you to the project 🎉

Copy link
Member

@sinclairpaul sinclairpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😉

@frenck frenck merged commit b6a2149 into master Feb 29, 2020
@frenck frenck deleted the core-mariadb-migration branch February 29, 2020 20:07
@addons-assistant
Copy link

Congrats on merging your first pull request! 🎉🎉🎉

talltechdude added a commit to talltechdude/addon-nginx-proxy-manager that referenced this pull request Mar 5, 2020
…y-manager

* 'upstream' of github.com:talltechdude/addon-nginx-proxy-manager:
  🔨 Update community forum links
  🔨 Re-branding
  📚 Update add-on instructions
  🔨 Adds migration to official MariaDB add-on (hassio-addons#77)
  ⬆️ Upgrades add-on base image to v7.0.2
  🚀 Remove unneeded eslint from build
  ⬆️ Upgrades nginx-proxy-manager to v2.1.1
  ⬆️ Upgrades mariadb to 10.4.12-r0
@addons-assistant
Copy link

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@addons-assistant addons-assistant bot locked as resolved and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants