Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also call after_any_fetch after user is set -> after_change_user #55

Closed

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Jun 7, 2012

I missed the point that users can also be just set in my first pull,
so I renamed the hook to reflect that its called after user was changed,
and added the callback to set_user and user + made sure it is not called twice

(our app has to change locale whenever user is changed)

@josevalim
Copy link
Contributor

I am fine with this change but @grosser wouldn't be better to simply have a callback for whenever fetch fails? We already have one for whenever fetch succeeds, so instead of having another callback overlapping, couldn't we simply have the counterpart?

@grosser
Copy link
Contributor Author

grosser commented Jun 8, 2012

I think that's a good idea, the combination will capture everything,
how about after_fetch_fail ?

@josevalim
Copy link
Contributor

Sounds great. Can we close this then and expect a new PR from you? :) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants