cli: do not clear metadata during metadata apply (close #6115) (#6119)

#6119
hasura · Nov 6, 2020 · 01c4cd2 · 01c4cd2
1 parent 153054b
commit 01c4cd2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -135,6 +135,7 @@ This release contains the [PDV refactor (#4111)](https://github.com/hasura/graph
 - console: down migrations improvements (close #3503, #4988) (#4790)
 - cli: add missing global flags for seed command (#5565)
 - cli: allow seeds as alias for seed command (#5693)
+- cli: fix bug in metadata apply which made the server aquire some redundant and unnecessary locks (close #6115)
 - docs: add docs page on networking with docker (close #4346) (#4811)
 - docs: add tabs for console / cli / api workflows (close #3593) (#4948)
 - docs: add postgres concepts page to docs (close #4440) (#4471)

diff --git a/cli/migrate/database/hasuradb/metadata.go b/cli/migrate/database/hasuradb/metadata.go
@@ -180,18 +180,9 @@ func (h *HasuraDB) ApplyMetadata() error {
 	if err != nil {
 		return err
 	}
-	query := HasuraInterfaceBulk{
-		Type: "bulk",
-		Args: []interface{}{
-			HasuraInterfaceQuery{
-				Type: "clear_metadata",
-				Args: HasuraArgs{},
-			},
-			HasuraInterfaceQuery{
-				Type: "replace_metadata",
-				Args: obj,
-			},
-		},
+	query := HasuraInterfaceQuery{
+		Type: "replace_metadata",
+		Args: obj,
 	}
 	resp, body, err := h.sendv1Query(query)
 	if err != nil {