Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: metadata apply should not clear_metadata #6115

Closed
tirumaraiselvan opened this issue Nov 2, 2020 · 0 comments
Closed

cli: metadata apply should not clear_metadata #6115

tirumaraiselvan opened this issue Nov 2, 2020 · 0 comments
Labels
c/cli Related to CLI p/high candidate for being included in the upcoming sprint

Comments

@tirumaraiselvan
Copy link
Contributor

tirumaraiselvan commented Nov 2, 2020 •
edited

replace_metadata clears the metadata while also keeping track of incremental schema cache generation. But, currently we are explicitly clearing the metadata (via clear_metadata) first :

graphql-engine/cli/migrate/database/hasuradb/metadata.go

Line 183 in 2592236

query := HasuraInterfaceBulk{

This totally voids the benefits of incremental schema cache generation. For example, it recreates event trigger functions even if they are not changed.
@tirumaraiselvan tirumaraiselvan added c/cli Related to CLI p/high candidate for being included in the upcoming sprint labels Nov 2, 2020
@tirumaraiselvan tirumaraiselvan mentioned this issue Nov 2, 2020
Closed
@scriptonist scriptonist mentioned this issue Nov 3, 2020
Merged
2 tasks
@tirumaraiselvan tirumaraiselvan modified the milestone: v1.3.3 Nov 3, 2020
@kodiakhq kodiakhq bot closed this as completed in 01c4cd2 Nov 6, 2020
codingkarthik pushed a commit to codingkarthik/graphql-engine that referenced this issue Nov 6, 2020
@scriptonist @codingkarthik
cli: do not clear metadata during metadata apply (close hasura#6115) (h…
ca07aaf 
…asura#6119)

hasura#6119
scriptonist added a commit to scriptonist/graphql-engine that referenced this issue Nov 8, 2020
@scriptonist
cli: do not clear metadata during metadata apply (close hasura#6115) (h…
1e45630 
…asura#6119)

hasura#6119
@tirumaraiselvan tirumaraiselvan mentioned this issue Dec 4, 2020
Closed
@tirumaraiselvan tirumaraiselvan mentioned this issue Jan 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/cli Related to CLI p/high candidate for being included in the upcoming sprint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tirumaraiselvan