Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta-data in column presets not updating after modification of a column type #1464

Closed
dafrie opened this issue Jan 24, 2019 · 0 comments · Fixed by #1473
Closed

Meta-data in column presets not updating after modification of a column type #1464

dafrie opened this issue Jan 24, 2019 · 0 comments · Fixed by #1473
Assignees
@rakeshkky
Labels
c/server Related to server e/quickfix can be wrapped up in few hours p/high candidate for being included in the upcoming sprint
Milestone
v1.0.0-alpha38

Comments

@dafrie
Copy link

dafrie commented Jan 24, 2019

Minor bug, but thought I would share it nevertheless:

When you modify the column type in a table (via the console, but I assume the same occurs with raw SQL...) and you have already existing column presets, it seems that the meta-data of the presets is not updated to the new type (which then results in an error when a mutation is submitted) nor it stops you when you modify the column type and warns you that there are dependencies on this column type (as it would do in case you have permission checks dependent on that column).
@karthikvt26 karthikvt26 added the c/server Related to server label Jan 24, 2019
@rakeshkky rakeshkky self-assigned this Jan 25, 2019
@rakeshkky rakeshkky added c/build-system Related to the build-release system e/quickfix can be wrapped up in few hours p/high candidate for being included in the upcoming sprint and removed c/build-system Related to the build-release system labels Jan 25, 2019
rakeshkky added a commit to rakeshkky/graphql-engine that referenced this issue Jan 25, 2019
@rakeshkky
restrict altering type of preset columns, fix hasura#1464
84c00ab
@rakeshkky rakeshkky mentioned this issue Jan 25, 2019
Merged
21 tasks
@0x777 0x777 added this to the v1.0.0-alpha38 milestone Jan 29, 2019
0x777 pushed a commit that referenced this issue Feb 11, 2019
@rakeshkky @0x777
support column presets in update mutation (closes #1449, closes #1464) (
cba732d 
#1473)

Also restricts altering type of columns which are used in presets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rakeshkky rakeshkky

Labels
c/server Related to server e/quickfix can be wrapped up in few hours p/high candidate for being included in the upcoming sprint
Projects
None yet
Milestone
v1.0.0-alpha38
4 participants
@dafrie @0x777 @rakeshkky @karthikvt26