Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote schema queries over websocket have wrong response structure #2246

Closed
ecthiender opened this issue May 21, 2019 · 0 comments
Closed

remote schema queries over websocket have wrong response structure #2246

ecthiender opened this issue May 21, 2019 · 0 comments
Assignees
@ecthiender
Labels
c/server Related to server e/quickfix can be wrapped up in few hours k/bug Something isn't working p/urgent Immediate action required

Comments

@ecthiender
Copy link
Member

ecthiender commented May 21, 2019 •
edited

The data key inside payload is nested twice, when websocket transport is used. via cli#5059 on Discord.

img
@ecthiender ecthiender added c/server Related to server k/bug Something isn't working labels May 21, 2019
@ecthiender ecthiender changed the title remote schema queries have wrong response structure remote schema queries over websocket have wrong response structure May 21, 2019
@ecthiender ecthiender added e/quickfix can be wrapped up in few hours p/urgent Immediate action required labels May 21, 2019
@ecthiender ecthiender self-assigned this May 21, 2019
@cescoferraro cescoferraro mentioned this issue May 21, 2019
Closed
ecthiender added a commit to ecthiender/graphql-engine that referenced this issue May 21, 2019
@ecthiender
fix response for remote schema queries over ws (fix hasura#2246)
100b7c0 
  remote schema queries over websocket would return nested data key in
  payload
@ecthiender ecthiender mentioned this issue May 21, 2019
Merged
@0x777 0x777 closed this as completed in 95a27fb May 29, 2019
polRk pushed a commit to polRk/graphql-engine that referenced this issue Feb 12, 2020
@ecthiender @polRk
fix response for remote schema queries over ws (fix hasura#2246) (has…
b9bd30a 
…ura#2248)
@sumodgeorge sumodgeorge mentioned this issue Dec 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecthiender ecthiender

Labels
c/server Related to server e/quickfix can be wrapped up in few hours k/bug Something isn't working p/urgent Immediate action required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ecthiender