Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbose logging #507

Closed
dsandip opened this issue Sep 21, 2018 · 5 comments
Closed

Verbose logging #507

dsandip opened this issue Sep 21, 2018 · 5 comments
Assignees
@ecthiender
Labels
c/server Related to server k/enhancement New feature or improve an existing feature p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints

Comments

@dsandip
Copy link
Member

dsandip commented Sep 21, 2018

via @praveenweb:

"we should enable verbose logging mode (via flag/env), where instead of just the query_hash, we get the actual query for better debugging".
@dsandip dsandip added k/enhancement New feature or improve an existing feature c/server Related to server p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints labels Sep 21, 2018
@elgordino
Copy link
Contributor

I would also like to see this feature for audit purposes. Logging queries and response times will enable analysis and reporting to aid detection of attacks and broken clients.

In the event of a security breach, query logging will be needed to see which data the attacker accessed.

@dsandip dsandip added this to the v1.0.0-alpha39 milestone Feb 1, 2019
@dsandip
Copy link
Member Author

dsandip commented Feb 5, 2019

from Prashantha on Discord - additional info needed: the PG tables/columns being accessed

@dsandip dsandip mentioned this issue Feb 13, 2019
Closed
@dsandip
Copy link
Member Author

dsandip commented Feb 13, 2019

Let's also add some numbers from #428 (which I am closing in favor of this one)

@dsandip dsandip mentioned this issue Feb 13, 2019
Closed
@dsandip dsandip assigned ecthiender and unassigned 0x777 Feb 13, 2019
@martinzwirner
Copy link

I would like to point out that verbose logging is important for subscriptions as well. At the moment performance values are logged only for queries.

@dsandip dsandip modified the milestones: v1.0.0-alpha39, v1.0.0-alpha40 Feb 28, 2019
@ecthiender ecthiender mentioned this issue Mar 21, 2019
Merged
@rikinsk-zz rikinsk-zz removed this from the v1.0.0-alpha42 milestone Jun 6, 2019
@mjonas87
Copy link

Any chance verbose logging could also spit out whether Hasura thinks you've configured it to use JWTs? Just had an issue where the HASURA_GRAPHQL_JWT_SECRET wasn't being set the right way because Windows.

polRk pushed a commit to polRk/graphql-engine that referenced this issue Feb 12, 2020
@ecthiender @polRk
breaking: server logging changes (close hasura#507, close hasura#2171) (
ac2818b 
hasura#1835)
hasura-bot pushed a commit that referenced this issue Apr 26, 2024
@danieljharvey @hasura-bot
create Docker images with Nix (#507)
4ea8818 
<!-- Thank you for submitting this PR! :) -->

## Description

In order to test things quicker, we'd like to be able to build custom
connector and friends in Nix, and then use the containers when running
tests. First step here is to be able to build Docker containers in Nix,
and add a CI job to ensure it still works.

Then we'll move onto publishing and using these images.

No-op build times:

<img width="336" alt="Screenshot 2024-04-25 at 15 53 56"
src="https://github.com/hasura/v3-engine/assets/4729125/47cbc0c5-6e54-4583-aa01-0528d4a21080">

Functional no-op.

V3_GIT_ORIGIN_REV_ID: 8f9d609e26cdd3b0801e61fd361c241ad504dcdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecthiender ecthiender

Labels
c/server Related to server k/enhancement New feature or improve an existing feature p/medium non-urgent issues/features that are candidates for being included in one of the upcoming sprints
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@rikinsk-zz @ecthiender @mjonas87 @0x777 @elgordino @martinzwirner @dsandip