Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change json field placeholder from 'asdf' to 'bar' (fix #1260) #1261

Merged
merged 1 commit into from Jan 28, 2019

Conversation

Anupam-dagar
Copy link
Contributor

@Anupam-dagar Anupam-dagar commented Dec 21, 2018

This changes the 'asdf' present in json field placeholder to 'bar'.

I have currently changed the placeholder text directly for edit and insert. Since the placeholders used are same, I suggest adding the placeholders to constant.js and importing them in both edit and insert js files.

Waiting for a review for the constants.js approach.

Update Commit

This PR changes the placeholder for JSON datatype. Along with it, the placeholders are now returned by the function defined in constants.js. This function was assigning the placeholder in InsertItem.js, now the function is in constants.js and imported in EditItem.js and InsertItem.js hence controlling the placeholders for both insert and edit components from one place.
Also, big integer and uuid datatype placeholders were missing from EditItem.js which are now added.

Fixes: #1260

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Hey @Anupam-dagar, thanks for your PR!

One of my human friends will review this PR and get back to you as soon as possible. 🕐

Stay awesome! 😎

@hasura-bot
Copy link
Contributor

Review app for commit a335173 deployed to Heroku: https://hge-ci-pull-1261.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1261-a335173

@praveenweb praveenweb added the c/console Related to console label Jan 2, 2019
@praveenweb
Copy link
Member

@Anupam-dagar - As you pointed out, its better to put in the re-used placeholders in a constants file. Look out for such existing files and see if you could add these to them instead of creating a new one.

@Anupam-dagar
Copy link
Contributor Author

@praveenweb sure, I will do that.

@hasura-bot
Copy link
Contributor

Review app for commit d60bbd7 deployed to Heroku: https://hge-ci-pull-1261.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1261-d60bbd7

Copy link
Member

@praveenweb praveenweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenweb praveenweb added the s/ok-to-merge Status: This pull request can be merged to master label Jan 24, 2019
@shahidhk shahidhk changed the title Change json field placeholder from 'asdf' to 'bar'. (Fix #1260) change json field placeholder from 'asdf' to 'bar' (fix #1260) Jan 28, 2019
@shahidhk shahidhk merged commit e528445 into hasura:master Jan 28, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1261.herokuapp.com is deleted

@hasura-bot
Copy link
Contributor

Beep boop! 🤖

Whoa! 🎉 🎉 💃

GIF

Awesome work @Anupam-dagar! 💪 🏆 All of us at Hasura ❤️ what you did.

Thanks again 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console Related to console s/ok-to-merge Status: This pull request can be merged to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the placeholder text in Json Insert Row field.
4 participants