New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change json field placeholder from 'asdf' to 'bar' (fix #1260) #1261
Conversation
Beep boop! 🤖 Hey @Anupam-dagar, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. 🕐 Stay awesome! 😎 |
Review app for commit a335173 deployed to Heroku: https://hge-ci-pull-1261.herokuapp.com |
@Anupam-dagar - As you pointed out, its better to put in the re-used placeholders in a constants file. Look out for such existing files and see if you could add these to them instead of creating a new one. |
@praveenweb sure, I will do that. |
a335173
to
28ae912
Compare
28ae912
to
d60bbd7
Compare
Review app for commit d60bbd7 deployed to Heroku: https://hge-ci-pull-1261.herokuapp.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Review app https://hge-ci-pull-1261.herokuapp.com is deleted |
Beep boop! 🤖 Whoa! 🎉 🎉 💃 Awesome work @Anupam-dagar! 💪 🏆 All of us at Hasura ❤️ what you did. Thanks again 🤗 |
This changes the 'asdf' present in json field placeholder to 'bar'.
I have currently changed the placeholder text directly for
edit
andinsert
. Since the placeholders used are same, I suggest adding the placeholders toconstant.js
and importing them in bothedit
andinsert
js files.Waiting for a review for the
constants.js
approach.Update Commit
This PR changes the placeholder for JSON datatype. Along with it, the placeholders are now returned by the function defined in
constants.js
. This function was assigning the placeholder inInsertItem.js
, now the function is inconstants.js
and imported inEditItem.js
andInsertItem.js
hence controlling the placeholders for both insert and edit components from one place.Also,
big integer
anduuid
datatype placeholders were missing fromEditItem.js
which are now added.Fixes: #1260
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Type
Checklist: