Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug where div keys repetition caused buggy render #1578

Merged
merged 2 commits into from Feb 11, 2019

Conversation

wawhal
Copy link
Contributor

@wawhal wawhal commented Feb 8, 2019

When you open the schema page on data tab in console, the suggested relations are generated with an iteration over a list and the key prop to each operator is the left-table of the suggested relation. In cases where relations for multiple tables are suggested, re-rendering is buggy because multiple elements have the same key and React looks at the key prop while performing incremental renders.

Description

What component does this PR affect?

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Requires changes from other components? If yes, please mark the components:

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System

Related Issue

Solution and Design

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update
  • Community content

Checklist:

  • I have read the contributing guide and my code conforms to the guidelines.
  • This change requires a change in the documentation.
  • I have updated the documentation accordingly.
  • I have added required tests.

@wawhal wawhal added k/bug Something isn't working c/console Related to console labels Feb 8, 2019
praveenweb
praveenweb previously approved these changes Feb 8, 2019
@coco98
Copy link
Contributor

coco98 commented Feb 8, 2019

@wawhal @praveenweb you should specify which UI element is affected so that its easy to QA. Esp since this doesnt seem to be linked to an issue or is internally tracked.

@hasura-bot
Copy link
Contributor

Review app for commit f7b049c deployed to Heroku: https://hge-ci-pull-1578.herokuapp.com
Docker image for server: hasura/graphql-engine:pull1578-f7b049c

@shahidhk
Copy link
Member

shahidhk commented Feb 9, 2019

@karthikvt26 One more review is required, esp. for functionality if it has to be verified. Please review.

Copy link

@rikinsk-zz rikinsk-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good

@wawhal wawhal added the s/ok-to-merge Status: This pull request can be merged to master label Feb 11, 2019
@shahidhk shahidhk merged commit ca7e216 into hasura:master Feb 11, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-1578.herokuapp.com is deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console Related to console k/bug Something isn't working s/ok-to-merge Status: This pull request can be merged to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants