New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a bug where div keys repetition caused buggy render #1578
fix a bug where div keys repetition caused buggy render #1578
Conversation
@wawhal @praveenweb you should specify which UI element is affected so that its easy to QA. Esp since this doesnt seem to be linked to an issue or is internally tracked. |
Review app for commit f7b049c deployed to Heroku: https://hge-ci-pull-1578.herokuapp.com |
@karthikvt26 One more review is required, esp. for functionality if it has to be verified. Please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good
Review app https://hge-ci-pull-1578.herokuapp.com is deleted |
When you open the schema page on data tab in console, the suggested relations are generated with an iteration over a list and the
key
prop to each operator is the left-table of the suggested relation. In cases where relations for multiple tables are suggested, re-rendering is buggy because multiple elements have the samekey
and React looks at thekey
prop while performing incremental renders.Description
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: