add multiline and rich editing to text fields Fix458 #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for hasura-docs ready! Built with commit 921ccd3 |
|
Review app for commit 501a328 deployed to Heroku: https://hge-ci-pull-2498.herokuapp.com |
|
Review app for commit f936de1 deployed to Heroku: https://hge-ci-pull-2498.herokuapp.com |
21 tasks
rikinsk-zz
approved these changes
Jul 22, 2019
|
Review app https://hge-ci-pull-2498.herokuapp.com is deleted |
|
Review app for commit 921ccd3 deployed to Heroku: https://hge-ci-pull-2498.herokuapp.com |
polRk
pushed a commit
to polRk/graphql-engine
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2281 # Description
This change uses the ACE editor already used for the JSON editor to edit text in several rich styles - as single line text, as multiline text, or with markdown or html syntax coloring support.
Affected components
Related Issues
#458
This PR replaces PR #1155
Solution and Design
Simply uses the pattern established by JsonInput.js
It would be best practice to refactor JsonInput, TextInput, and some notional BooleanInput into a common superclass, but that wasn't my marching orders.
Steps to test and verify
make a table with text type column
insert a row
use the widget in UR of entry area to cycle through styles
Limitations, known bugs & workarounds
We cycle through the modes with the button. This is a design compromise worked out by Anu and I as consistent with the JSON one and simple to implement. If we ever want to expand the list it'll become cumbersome, but we can change to a drop down menu at that time.