Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape comment strings in console to allow quotes in PG comments #2676

Merged
merged 7 commits into from
Aug 9, 2019

Conversation

rikinsk-zz
Copy link

@rikinsk-zz rikinsk-zz commented Aug 6, 2019

Description

  • escape all comment strings

Misc

  • show error details if error in dropping inconsistent metadata
  • minor refactor for admin secret in explorer

Affected components

  • Console

Related Issues

#2641

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

@netlify
Copy link

netlify bot commented Aug 6, 2019

Deploy preview for hasura-docs ready!

Built with commit e368703

https://deploy-preview-2676--hasura-docs.netlify.com

@rikinsk-zz rikinsk-zz requested a review from wawhal August 6, 2019 13:55
@rikinsk-zz rikinsk-zz added the c/console Related to console label Aug 6, 2019
@hasura-bot
Copy link
Contributor

Review app for commit 9c1b62b deployed to Heroku: https://hge-ci-pull-2676.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2676-9c1b62bd

Copy link
Contributor

@wawhal wawhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rikinsk-zz rikinsk-zz merged commit c793858 into hasura:master Aug 9, 2019
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-2676.herokuapp.com is deleted

@rikinsk-zz rikinsk-zz deleted the console-escape-comments branch August 9, 2019 10:51
@hasura-bot
Copy link
Contributor

Review app for commit e368703 deployed to Heroku: https://hge-ci-pull-2676.herokuapp.com
Docker image for server: hasura/graphql-engine:pull2676-e3687032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/console Related to console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants