Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc console improvements #3435

Merged
merged 14 commits into from
Jan 7, 2020
Merged

misc console improvements #3435

merged 14 commits into from
Jan 7, 2020

Conversation

rikinsk
Copy link
Member

@rikinsk rikinsk commented Nov 27, 2019 •
edited
Loading

Description

  • persist rawSql content to LS
  • handle cleanup of admin secret related persisted info if admin secret is removed
  • show gql compatibility warning for invalid schemas and add to tooltip that types depending on the identifier will not be exposed over GraphQL
  • display non trackable functions section even if there are no functions
  • increase width of stack trace container on error page

Affected components

  • Server
  • Console
  • CLI
  • Docs
  • Community Content
  • Build System
  • Tests
  • Other (list it)

Related Issues

Solution and Design

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes
    • Updated docs with SQL for downgrading the catalog

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes
    • Does run_sql auto manages the new metadata through schema diffing?
      • Yes
      • Not required
    • Does run_sql auto manages the definitions of metadata on renaming?
      • Yes
      • Not required
    • Does export_metadata/replace_metadata supports the new metadata added?
      • Yes
      • Not required

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated:
    • New types and typenames are correlated

Breaking changes

  • No Breaking changes

  • There are breaking changes:

    1. Metadata API

      Existing query types:

      • Modify args payload which is not backward compatible
      • Behavioural change of the API
      • Change in response JSON schema
      • Change in error code

    2. GraphQL API

      Schema Generation:

      • Change in any NamedType
      • Change in table field names

      Schema Resolve:-

      • Change in treatment of null value for any input fields

    3. Logging

      • Log JSON schema has changed
      • Log type names have changed

Steps to test and verify

Limitations, known bugs & workarounds

@rikinsk rikinsk added the c/console Related to console label Nov 27, 2019
@rikinsk rikinsk requested a review from wawhal November 27, 2019 15:33
@netlify
Copy link

netlify bot commented Nov 27, 2019 •
edited
Loading

Deploy preview for hasura-docs ready!

Built with commit 7fece8a

https://deploy-preview-3435--hasura-docs.netlify.com

@hasura-bot
Copy link
Contributor

Review app for commit 36cbb69 deployed to Heroku: https://hge-ci-pull-3435.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3435-36cbb691

@hasura-bot
Copy link
Contributor

Review app for commit f344387 deployed to Heroku: https://hge-ci-pull-3435.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3435-f3443872

@rikinsk rikinsk removed the request for review from wawhal November 28, 2019 09:57
@rikinsk rikinsk added the s/wip Status: This issue is a work in progress label Nov 28, 2019
@hasura-bot
Copy link
Contributor

Review app for commit b714990 deployed to Heroku: https://hge-ci-pull-3435.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3435-b7149906

@rikinsk rikinsk removed the s/wip Status: This issue is a work in progress label Nov 28, 2019
@rikinsk rikinsk requested a review from wawhal November 28, 2019 11:35
@rikinsk
Merge branch 'master' into console-misc
8786a9e
@rikinsk
Merge branch 'master' into console-misc
0408a05 
 Conflicts:
	console/src/components/Services/Data/Schema/Schema.js
	console/src/components/Services/Data/TableRelationships/RelationshipEditor.js
@hasura-bot
Copy link
Contributor

Review app for commit 0408a05 deployed to Heroku: https://hge-ci-pull-3435.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3435-0408a052

@hasura-bot
Copy link
Contributor

Review app for commit dc7092d deployed to Heroku: https://hge-ci-pull-3435.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3435-dc7092da

wawhal
wawhal previously approved these changes Jan 7, 2020
View reviewed changes
wawhal
wawhal previously approved these changes Jan 7, 2020
View reviewed changes
@hasura-bot
Copy link
Contributor

Review app for commit 40ea0a9 deployed to Heroku: https://hge-ci-pull-3435.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3435-40ea0a97

@rikinsk rikinsk requested a review from wawhal January 7, 2020 09:16
@hasura-bot
Copy link
Contributor

Review app for commit 7fece8a deployed to Heroku: https://hge-ci-pull-3435.herokuapp.com
Docker image for server: hasura/graphql-engine:pull3435-7fece8af

@rikinsk rikinsk merged commit dbfc9e2 into hasura:master Jan 7, 2020
@hasura-bot
Copy link
Contributor

Review app https://hge-ci-pull-3435.herokuapp.com is deleted

@rikinsk rikinsk deleted the console-misc branch January 7, 2020 09:21
polRk pushed a commit to polRk/graphql-engine that referenced this pull request Feb 12, 2020
@rikinsk @polRk
misc console improvements (hasura#3435)
7f10f03 
* persist rawSql content to LS
* handle cleanup of admin secret related persisted info if admin secret is removed
* show gql compatibility warning for invalid schemas and add to tooltip that types depending on the identifier will not be exposed over GraphQL
* display non trackable functions section even if there are no functions
* increase width of stack trace container on error page
* fix PG version fetch query
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawhal wawhal wawhal approved these changes

Assignees

@wawhal wawhal

Labels
c/console Related to console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikinsk @hasura-bot @wawhal