include scalars types returning by computed fields in generated schema (fix #3650) #3651
Conversation
|
Deploy preview for hasura-docs ready! Built with commit 2391d86 |
There was a problem hiding this comment.
Hm, actually, I initially approved this PR, but it looks like the tests are failing in CI. @rakeshkky, could you figure out what’s going wrong?
|
Review app for commit 51d289b deployed to Heroku: https://hge-ci-pull-3651.herokuapp.com |
|
Review app for commit 44d06a1 deployed to Heroku: https://hge-ci-pull-3651.herokuapp.com |
|
Review app for commit 1d65dcb deployed to Heroku: https://hge-ci-pull-3651.herokuapp.com |
|
Review app for commit 2391d86 deployed to Heroku: https://hge-ci-pull-3651.herokuapp.com |
|
Review app https://hge-ci-pull-3651.herokuapp.com is deleted |
Description
Scalar types returning by scalar computed fields are not included in generated GraphQL schema. And hence the introspection query and GraphQL queries fail. This PR fixes the same.
Affected components
Related Issues
Fix #3650
Solution and Design
Include the
PGScalarTypeof scalar computed fields inadditionalScalarswhile generating GraphQL context.Steps to test and verify
Add a scalar computed field which returns uncommon scalar type and perform the graphql query.
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Fixes the GraphQL schema generation for scalar computed fields.
Breaking changes