Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pull request template (close #473) #488

Merged
merged 18 commits into from Sep 20, 2018
Merged
1 change: 1 addition & 0 deletions .ciignore
Expand Up @@ -7,3 +7,4 @@ community/*
install-manifests/*
.ciignore
.gitignore
.github/*
52 changes: 52 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
@@ -0,0 +1,52 @@
<!-- Thank you for submitting this PR! :) -->
<!-- Provide a general summary of your changes in the Title above, end with (close #<issue-no>) or (fix #<issue-no>) -->

### Description
<!-- Describe your changes in detail -->

<!-- Please put an `x` in the boxes below -->

What component does this PR affect?

- [ ] Server
- [ ] Console
- [ ] CLI
- [ ] Docs
- [ ] Community Content

Requires changes from other components? If yes, please mark the components:

- [ ] Server
- [ ] Console
- [ ] CLI
- [ ] Docs
- [ ] Community Content

### Related Issue
<!-- Please make sure you have an issue associated with this Pull Request -->
<!-- If you are suggesting a new feature or change, please discuss it in an issue first -->
<!-- If you are fixing a bug, there should be an issue describing it with steps to reproduce -->
<!-- Please don't forget to add `(close/fix #<issue-no>)` to the pull request title -->

<!-- Please link to the issue here: -->

### Solution and Design
<!-- How is this issue solved/fixed? What is the design? -->
<!-- It's better if we elaborate -->

### Tests
<!-- Please describe in detail how you tested your changes. -->
<!-- Each component has it's own testing framework, check it out and add your tests to the mix -->

### Type
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

### Checklist:
shark-h marked this conversation as resolved.
Show resolved Hide resolved
<!-- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] I have read the **[contributing guide](https://github.com/hasura/graphql-engine/blob/master/CONTRIBUTING.md)** and my code conforms to the guidelines.
- [ ] This change requires a change in the documentation.
- [ ] I have updated the documentation accordingly.
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -16,11 +16,11 @@ Read more at [hasura.io](https://hasura.io) and the [docs](https://docs.hasura.i

------------------

![Hasura GraphQL Enigne Demo](assets/demo.gif)
![Hasura GraphQL Engine Demo](assets/demo.gif)

------------------

![Hasura GraphQL Engine Readltime Demo](assets/realtime.gif)
![Hasura GraphQL Engine Realtime Demo](assets/realtime.gif)

-------------------

Expand Down
Binary file modified assets/demo.gif
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.