docs: add page on created_at / updated_at timestamps (close #2880) #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marionschleifer
changed the title
|
Deploy preview for hasura-docs ready! Built with commit 9ddbb25 |
|
Deploy preview for hasura-docs ready! Built with commit dc36c1a |
sezgi
approved these changes
Jun 26, 2020
rikinsk
requested changes
Jul 1, 2020
There was a problem hiding this comment.
- can we just call the page "Adding created_at / updated_at timestamps" as that is what the page is actually talking about. The current title and presentation left me extremely confused about the intent of this page. created_at and updated_at are not exactly default values for timestamp values but are rather special columns whose values can be set by using some default values
updated_atis not achievable by adding a simple default value. One needs to add a postgres trigger that updates the timestamp value after each update. Hence the instructions under the ClI/API tab are inaccurate
marionschleifer
changed the title
rikinsk
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
@marionschleifer This looks good. Just one change, for the updated_at code-block you might want to use code-block:: plpgsql in place of code-block:: sql to get the highlighting to work
@sezgi The page has kind of changed completely so you should take a look at the changes again I guess. Also, I havent verified all the instructions.
sezgi
reviewed
Jul 10, 2020
docs/graphql/manual/schema/default-values/created-updated-timestamps.rst
Show resolved
Hide resolved
docs/graphql/manual/schema/default-values/created-updated-timestamps.rst
Show resolved
Hide resolved
|
@sezgi please see the changes. |
sezgi
approved these changes
Jul 11, 2020
|
Review app https://hge-ci-pull-5223.herokuapp.com is deleted |
marionschleifer
added a commit
to marionschleifer/graphql-engine
that referenced
this pull request
Jul 20, 2020
stevefan1999-personal
pushed a commit
to stevefan1999-personal/graphql-engine
that referenced
this pull request
Sep 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a page on default timestamp values to make this information easier to find for users.
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
#2880
Added page
https://deploy-preview-5223--hasura-docs.netlify.app/graphql/manual/schema/default-values/created-updated-timestamps.html