server: avoid raising mutation check constraint violation in pg procedure #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakeshkky
added
c/server
-> Raise check constraint error in Haskell code itself. -> Avoid usage of hdb_catalog.check_constraint procedure
rakeshkky
force-pushed
the
5797-check-constraint
branch
from
a934764
to
840e59a
Compare
abooij
reviewed
Nov 3, 2020
Co-authored-by: Auke Booij <auke@tulcod.com>
abooij
changed the title
7 tasks
0x777
requested changes
Nov 4, 2020
rakeshkky
force-pushed
the
5797-check-constraint
branch
from
23e9c85
to
fb16638
Compare
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
|
Deploy preview for hasura-docs ready! Built with commit 86dd527 |
Resolve Conflicts: server/src-lib/Hasura/Backends/Postgres/Execute/RemoteJoin.hs
rakeshkky
force-pushed
the
5797-check-constraint
branch
from
1bb7871
to
ba37f11
Compare
rakeshkky
force-pushed
the
5797-check-constraint
branch
from
ba37f11
to
26395f3
Compare
0x777
requested changes
Nov 5, 2020
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
|
@0x777 Please have a final look at the PR. |
0x777
approved these changes
Nov 6, 2020
|
Ah, this introduced some Postgres-specific code in |
scriptonist
pushed a commit
to scriptonist/graphql-engine
that referenced
this pull request
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is incremental PR towards #5797. It removes dependency on
hdb_catalog.check_violationpg procedure to raise mutation (insert & update) check constraint violation exception. Instead, the check constraint violation error is thrown in Haskell code itself.Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Related Issues
Refer the PR #5797
Solution and Design
SQL is generated such a way that it returns a nullable error message column
check__constraintwhich is result of a check constraint evaluation.In Haskell code, the error is raised when
check__errorcolumn is not null.Steps to test and verify
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes