Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata separation in catalog #6184

Closed
wants to merge 18 commits into from

Conversation

rakeshkky
Copy link
Member

@rakeshkky rakeshkky commented Nov 12, 2020

Description

This is an incremental PR towards #5797. It migrates catalog which drops tables/views related to metadata and stores the metadata as a JSON blob in one table and in one row. This PR has following core changes

  • Catalog migration
  • Schema cache is build from Metadata type instead of CatalogMetadata type.
  • Each /v1/query carries Metadata in state to be able to modify via MetadataM class monad.

Changelog

  • CHANGELOG.md is updated with user-facing content relevant to this PR. If no changelog is required, then add the no-changelog-required label.

Affected components

  • Server
  • Tests -- Modifies few pytests which involves in checking up with catalog tables.

Related Issues

Solution and Design

Steps to test and verify

Limitations, known bugs & workarounds

Server checklist

Catalog upgrade

Does this PR change Hasura Catalog version?

  • No
  • Yes

Metadata

Does this PR add a new Metadata feature?

  • No
  • Yes

GraphQL

  • No new GraphQL schema is generated
  • New GraphQL schema is being generated

Breaking changes

  • No Breaking changes
  • There are breaking changes

@kodiakhq
Copy link
Contributor

kodiakhq bot commented Nov 12, 2020

This PR currently has a merge conflict. Please resolve this and then re-add the auto-update-auto-merge label.

Resolve Conflicts:
	server/src-lib/Hasura/RQL/DDL/EventTrigger.hs
	server/src-lib/Hasura/RQL/DDL/Metadata.hs
	server/src-lib/Hasura/RQL/DDL/Schema/Cache.hs
	server/src-lib/Hasura/RQL/DDL/Schema/Diff.hs
	server/src-rsr/initialise.sql
	server/src-rsr/migrations/41_to_42.sql
	server/src-rsr/migrations/42_to_41.sql
Resolve Conflicts:
	server/src-lib/Hasura/RQL/DDL/Schema/Function.hs
	server/src-lib/Hasura/RQL/Types/Function.hs
Resolve Conflicts:
	server/src-exec/Main.hs
	server/src-lib/Hasura/App.hs
	server/src-lib/Hasura/Server/API/Query.hs
	server/src-lib/Hasura/Server/SchemaUpdate.hs
@rakeshkky rakeshkky marked this pull request as ready for review November 24, 2020 15:10
@rakeshkky rakeshkky requested a review from 0x777 November 24, 2020 15:10
@abooij
Copy link
Contributor

abooij commented Jul 12, 2022

This was merged a looong time ago in a2cf9a5 through the mono repo.

@abooij abooij closed this Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants