-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metadata separation in catalog #6184
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested by @abooij
rakeshkky
added
c/server
Related to server
no-changelog-required
auto-update-auto-merge
labels
Nov 12, 2020
This PR currently has a merge conflict. Please resolve this and then re-add the |
Resolve Conflicts: server/src-lib/Hasura/RQL/DDL/EventTrigger.hs server/src-lib/Hasura/RQL/DDL/Metadata.hs server/src-lib/Hasura/RQL/DDL/Schema/Cache.hs server/src-lib/Hasura/RQL/DDL/Schema/Diff.hs server/src-rsr/initialise.sql server/src-rsr/migrations/41_to_42.sql server/src-rsr/migrations/42_to_41.sql
rakeshkky
force-pushed
the
5797-metadata-separation
branch
from
November 17, 2020 13:12
6f82c18
to
fc193bc
Compare
Resolve Conflicts: server/src-lib/Hasura/RQL/DDL/Schema/Function.hs server/src-lib/Hasura/RQL/Types/Function.hs
Resolve Conflicts: server/src-exec/Main.hs server/src-lib/Hasura/App.hs server/src-lib/Hasura/Server/API/Query.hs server/src-lib/Hasura/Server/SchemaUpdate.hs
This was merged a looong time ago in a2cf9a5 through the mono repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an incremental PR towards #5797. It migrates catalog which drops tables/views related to metadata and stores the metadata as a JSON blob in one table and in one row. This PR has following core changes
Metadata
type instead ofCatalogMetadata
type.Metadata
in state to be able to modify viaMetadataM
class monad.Changelog
CHANGELOG.md
is updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-required
label.Affected components
Related Issues
Solution and Design
Steps to test and verify
Limitations, known bugs & workarounds
Server checklist
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes