-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community: Convert real-time poll sample app to hooks [closes #7675] #7694
Conversation
Beep boop! 🤖 Hey @andykcom, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
@praveenweb , can you please add no-changelog-required tag? Thanks! |
✔️ Deploy Preview for hasura-docs ready! 🔨 Explore the source changes: ed77611 🔍 Inspect the deploy log: https://app.netlify.com/sites/hasura-docs/deploys/61776e5dbedb21000728a765 😎 Browse the preview: https://deploy-preview-7694--hasura-docs.netlify.app |
/changelog ok |
GITHUB_PR_NUMBER: 7694 GITHUB_PR_URL: #7694 PR-URL: hasura/graphql-engine-mono#2620 Co-authored-by: andykcom <532952+andykcom@users.noreply.github.com> GitOrigin-RevId: 428d9a1
Beep boop! 🤖 Awesome work @andykcom! Your changes were merged successfully. All of us at Hasura ❤️ what you did. Thanks again 🤗 |
Hey @andykcom, 👋🏼 Thanks so much for contributing to Hasura through Hacktoberfest 2021! As a token of appreciation, we'd love to send you some swag. Do keep an eye out for an email with the link to the swag form. Do fill it out and your swag will be on its way soon! ❤️ Cheers! |
Description
The PR updates the Real-time Poll sample app to use Apollo v3, converts the application from class-based components to functional components, and cleans up the code structure. The changes are internal only and do not affect functionality or look of the sample app.
Changelog
CHANGELOG.md
is updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-required
label.Affected components
Related Issues
Solution and Design
The old system was written 3 years ago when the implementation of the Apollo library used , , and components to fetch the data. Newer release of Apollo moved to a hooks-based approach.
The new design of the app leverages React hooks for a more modern and readable code.
Steps to test and verify
Manually tested the workflow.
Limitations, known bugs & workarounds
N/A
Server checklist
N/A
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
run_sql
auto manages the new metadata through schema diffing?run_sql
auto manages the definitions of metadata on renaming?export_metadata
/replace_metadata
supports the new metadata added?GraphQL
Breaking changes
No Breaking changes
There are breaking changes:
Metadata API
Existing
query
types:args
payload which is not backward compatibleJSON
schemaGraphQL API
Schema Generation:
NamedType
Schema Resolve:-
null
value for any input fieldsLogging
JSON
schema has changedtype
names have changed