clarify which server uses the shared secret too #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Beep boop! 🤖 Hey @patcito, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. 🕐 Stay awesome! 😎 |
|
It should be auth server and not graphql engine. The sentence probably should not
end with "as well".
…On Monday, October 29, 2018, Tanmai Gopal ***@***.***> wrote:
@ecthiender <https://github.com/ecthiender> @rikinsk
<https://github.com/rikinsk> 👆
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#925 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAlnw1HIxwlqUAcqyi-3ehbCqIglQ6kFks5upzr7gaJpZM4X_kXA>
.
|
dsandip
requested changes
Nov 2, 2018
docs/graphql/manual/auth/jwt.rst
Outdated
| @@ -185,7 +185,7 @@ Your auth server is using HMAC-SHA algorithms to sign JWTs, and is using a | |||
| "key": "3EK6FD+o0+c7tzBNVfjpMkNDi2yARAAKzQlk8O2IKoxQu4nF7EdAh8s3TwpHwrdWT6R" | |||
| } | |||
|
|
|||
| The ``key`` is the actual shared secret, which is used by your auth server as well. | |||
| The ``key`` is the actual shared secret, which is used by your Hasura graphql-engine server as well. | |||
There was a problem hiding this comment.
Suggested change
| The ``key`` is the actual shared secret, which is used by your Hasura graphql-engine server as well. | |
| The ``key`` is the actual shared secret, which is also used by your auth server. |
shahidhk
changed the title
shahidhk
approved these changes
Nov 8, 2018
|
Review app https://hge-ci-pull-925.herokuapp.com is deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a small error in documentation about jwt.
Description
I think this sentence was referring the graphql-engine and not the auth server.
What component does this PR affect?
Requires changes from other components? If yes, please mark the components:
Related Issue
Solution and Design
Type
Checklist: