-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(server): fix typo in Schema.hs #9702
base: master
Are you sure you want to change the base?
Conversation
additionaly -> additionally
Beep boop! 🤖 Hey @eltociear, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can confirm spelling is fixed
-- * The /catalog/ refers to the set of PostgreSQL tables and views that store all schema information | ||
-- known by Hasura. This includes any tracked Postgres tables, views, and functions, all remote | ||
-- schemas, and any additionaly Hasura-specific information such as permissions and relationships. | ||
-- schemas, and any additionally Hasura-specific information such as permissions and relationships. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, shouldn't it say and any additional Hasura-specific information
?
@hallettj FYI, to add this PR to the merge queue, you have to approve the corresponding PR on the mono repo. |
Description
Fix a misspelled word in a comment: additionaly -> additionally
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
run_sql
auto manages the new metadata through schema diffing?run_sql
auto manages the definitions of metadata on renaming?export_metadata
/replace_metadata
supports the new metadata added?GraphQL
Breaking changes
No Breaking changes
There are breaking changes:
Metadata API
Existing
query
types:args
payload which is not backward compatibleJSON
schemaGraphQL API
Schema Generation:
NamedType
Schema Resolve:-
null
value for any input fieldsLogging
JSON
schema has changedtype
names have changed