Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer of Story #22

Merged
merged 1 commit into from
Jul 3, 2014
Merged

Viewer of Story #22

merged 1 commit into from
Jul 3, 2014

Conversation

liamcottle
Copy link
Contributor

A user that has viewed a story that belongs to you.

A user that has viewed a story that belongs to you.
@jamesst20
Copy link
Collaborator

Thanks for this too :) The javadoc is missing for the "getTimeStamp"

Also, there is something I don't understand in a comment you made :
private static final String SCREENSHOTTED_KEY = "screenshotted"; //Always : If your story has been viewed or not.

By saying "Always : If your story has been viewed or not.", I don't understand what it should mean because a "Viewer" must have seen it otherwise it is not a viewer, so what does it mean?

I will merge anyway because it is required for other commits but I hope you will correct the mistakes :)

jamesst20 added a commit that referenced this pull request Jul 3, 2014
@jamesst20 jamesst20 merged commit 47c5a12 into hatboysam:master Jul 3, 2014
@liamcottle
Copy link
Contributor Author

I'll tidy this up later ;)
On 4/07/2014 2:47 AM, "jamesst20" notifications@github.com wrote:

Merged #22 #22.


Reply to this email directly or view it on GitHub
#22 (comment).

@jamesst20
Copy link
Collaborator

Alright :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants