feat: custom claims for setting grpc/server addr in token #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the requirement of setting
HATCHET_CLIENT_HOST_PORT
as an environment variable in all of the SDKs. This instead adds custom claims ofserver_url
andgrpc_broadcast_address
which are used for connections.Security implications of this approach were considered - one could consider a MITM attack which rewrites the claims to trick the user into sending their token to their server. Our SDKs require TLS to minimize the risk, and if an attacker has constructed a MITM attack during token generation time, they would likely be able to modify the payload which shows the broadcast address to the user anyway. This is also fairly standard practice, i.e. GCP credentials files have a set of auth URIs set:
Type of change
Please delete options that are not relevant.
What's Changed
This is backwards-compatible with older tokens.
HATCHET_CLIENT_HOST_PORT