delete other filesの処理を修正 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halkt
reviewed
Dec 7, 2023
| for file in ${delete_files[@]}; do | ||
| rm "$file" | ||
| done | ||
|
|
||
| restore_files=($(grep -xL "EditURL: ${{ steps.set-entry-variables.outputs.EDIT_URL }}" $(git ls-files -m --exclude-standard))) | ||
| for file in ${resotre_files[@]}; do | ||
| restore_files=(git ls-files -m --exclude-standard | xargs -r grep -xL "EditURL: ${{ steps.set-entry-variables.outputs.EDIT_URL }}") |
There was a problem hiding this comment.
[must]$が抜けてそうでした.
Suggested change
| restore_files=(git ls-files -m --exclude-standard | xargs -r grep -xL "EditURL: ${{ steps.set-entry-variables.outputs.EDIT_URL }}") | |
| restore_files=$(git ls-files -m --exclude-standard | xargs -r grep -xL "EditURL: ${{ steps.set-entry-variables.outputs.EDIT_URL }}") |
halkt
reviewed
Dec 7, 2023
| @@ -29,13 +29,14 @@ runs: | |||
| shell: bash | |||
| - name: delete other files | |||
| run: | | |||
| delete_files=($(grep -xL "EditURL: ${{ steps.set-entry-variables.outputs.EDIT_URL }}" $(git ls-files -o --exclude-standard))) | |||
| set +eo pipefail | |||
| delete_files=$(git ls-files -o --exclude-standard | xargs -r grep -xL "EditURL: ${{ steps.set-entry-variables.outputs.EDIT_URL }}") | |||
There was a problem hiding this comment.
[should]restore_files の方もですが, ()で括っていないので配列じゃなくなっていそうです.
|
レビューありがとうございます。2箇所とも治したほうが良さそうだったので治しました |
|
dmdm~ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#45 の修正が不完全だったので追い修正です
grep -xL "EditURL" $(git ls-files)形式だと、git ls-filesの結果がなかったときgrepがstdinから読もうとしてしまいそうなのでxargs -rを利用するように（-rは--no-run-if-emptyの短縮形）-eと-o pipefailをなしに