Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y audit fixes #4

Closed
1 task done
carylwyatt opened this issue May 8, 2024 · 3 comments
Closed
1 task done

a11y audit fixes #4

carylwyatt opened this issue May 8, 2024 · 3 comments

Comments

@carylwyatt
Copy link
Member

carylwyatt commented May 8, 2024 •
edited
Loading

  • 1727272 screen reader can't tell if search result facet accordions are in expanded or collapsed state
    • fix: the accordion is part of the mdp-web skeleton. it's already setting aria-expanded=true if the accordion is open but we also need to set aria-expanded=false if not open. the upside to this being in mdp-web is that it will fix the issue for mb at the same time.
@angelinanz
Copy link

angelinanz commented May 8, 2024 •
edited by jira bot
Loading

This is also captured in DEV-1172

aelkiss added a commit that referenced this issue May 8, 2024
@aelkiss
DEV-1172: WIP: aria-expanded="false" for default-collapsed accordions
1e451be 
Addresses #4 / Deque issue 1727272

I don't have any full-text search index locally so I can't immediately
reproduce this, but I wanted to get some WIP up and test further.
@aelkiss aelkiss mentioned this issue May 8, 2024
Merged
@aelkiss
Copy link
Member

aelkiss commented May 9, 2024

This is staged on test.babel.hathitrust.org

@carylwyatt
Copy link
Member Author

Deployed yesterday via PR #5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aelkiss @carylwyatt @angelinanz