-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump NuGet packages. Fix versions for .NET 6 and 7. #792
Merged
hakenr
merged 1 commit into
havit:master
from
EnchantedCoder:issue/update-nuget-packages
Apr 18, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EnchantedCoder What type of NuGet package restore would failure did you encounter?
These packages (3) are only used in the documentation, which is
net8.0
-only and does not use multi-targeting.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Havit.Blazor.Grpc.Client was failing to restore packages, complaining that the 8.0.x version is only compatible with .NET 8, as soon as I updated to 8.0.4. Making that change in the central package management file allowed it to restore and build normally again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I will try to replay that scenario on my side.
(
Havit.Blazor.Grpc.Client
does not reference any of theMicrosoft.AspNetCore.Components.WebAssembly.*
packages.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged into master, tried to remove the .NET6 + 7 PackageVersions for those three packages and still able to restore (incl.
dotnet restore -f
).@EnchantedCoder I will push that commit to master. Can you please try to double-check on your side?