This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Fix Issue 132: Reduce Docker image size #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimalek71
changed the title
haohaolee
reviewed
Oct 25, 2019
Dockerfile.alpine
Outdated
| && wget --quiet https://github.com/find-sec-bugs/find-sec-bugs/releases/download/version-${FINDSECBUGS_VERSION}/findsecbugs-cli-${FINDSECBUGS_VERSION}.zip \ | ||
| && unzip -q findsecbugs-cli-${FINDSECBUGS_VERSION}.zip \ | ||
| && rm findsecbugs.sh \ | ||
| && curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y |
There was a problem hiding this comment.
I am not sure if cargo-audit is the only thing we need, I mean the binary. If yes, we don't have to install rust compiler in our final image. @felixhammerl
CzarScar
reviewed
Nov 19, 2019
CzarScar
reviewed
Nov 20, 2019
Changes: - Add missing `cd` - Fix OWASP scan due to missing database
|
merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new alpine base Dockerfile and reduce the size of the image (see Dockerfile.alpine)
Fixes #132
Toolchain
How Has This Been Tested?
I need help to test all functionality and a sanity test for this new docker image.
Notes for the reviewer
For simplicity and reduce the time of build, you can pull the docker image from here.
docker pull alimalek/scanner-cliChecklist: