Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crash on non-existent courses prop #2200

Closed
wants to merge 2 commits into from
Closed

Prevent crash on non-existent courses prop #2200

wants to merge 2 commits into from

Conversation

drewvolz
Copy link
Collaborator

Resolves #2199

@drewvolz drewvolz requested a review from hawkrives April 11, 2018 23:10
@drewvolz
Copy link
Collaborator Author

drewvolz commented Apr 11, 2018 •
edited
Loading

diff without whitespace https://github.com/hawkrives/gobbldygook/pull/2200/files?w=1

@hawkrives
Copy link
Owner

I appreciate the PR, but this should be fixed at the source – this object should always have a courses property at this point, even if it's an empty array.

@hawkrives
Copy link
Owner

so I haven't figured out why it's null here, but I added an array ||[] elsewhere.

thanks!

@hawkrives hawkrives closed this Apr 14, 2018
@hawkrives hawkrives deleted the fix-course-list-map branch April 14, 2018 14:46
@drewvolz drewvolz mentioned this pull request Apr 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkrives hawkrives Awaiting requested review from hawkrives

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewvolz @hawkrives