-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a virtualized list for course results #2216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hawkrives
force-pushed
the
virtual-list
branch
2 times, most recently
from
July 23, 2018 00:47
1729d2a
to
095d426
Compare
hawkrives
force-pushed
the
virtual-list
branch
from
September 22, 2018 05:40
b67c8e2
to
1bb5ba6
Compare
and make it fit the screen properly
hawkrives
force-pushed
the
virtual-list
branch
from
September 23, 2018 00:53
d51a05b
to
7525abb
Compare
closes #2256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An experiment with using react-virtualized to render only part of the course search results at any given time.
Playground link: https://deploy-preview-2216--gobbldygook.netlify.com/
TODO:
Fix duplication of react-virtualized in bundles18kb each is much more palatable than 245kb each