Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a virtualized list for course results #2216

Merged
merged 28 commits into from
Sep 23, 2018
Merged

Use a virtualized list for course results #2216

merged 28 commits into from
Sep 23, 2018

Conversation

hawkrives
Copy link
Owner

@hawkrives hawkrives commented Apr 16, 2018

An experiment with using react-virtualized to render only part of the course search results at any given time.

Playground link: https://deploy-preview-2216--gobbldygook.netlify.com/

TODO:

  • Figure out grouping – I had to remove the card-like sections from the groupings for this first attempt
  • Check whether sorting / grouping still works
  • Fix search result list height – and how does that whole left-hand-scrollable column work here?
  • Fix duplication of react-virtualized in bundles 18kb each is much more palatable than 245kb each
  • Fix searching on the overview page

@buildsize
Copy link

buildsize bot commented Apr 16, 2018

File name Previous Size New Size Change
404.html 861 bytes 861 bytes 0 bytes (0%)
app.css 84.13 KB 90.73 KB 6.61 KB (8%)
app.js 994.18 KB 994.45 KB 272 bytes (0%)
areaData.url 50 bytes 50 bytes 0 bytes (0%)
chunk.area-editor.components.js 201.2 KB 201.22 KB 27 bytes (0%)
chunk.course-overlay.components.js 69.71 KB 87.7 KB 17.99 KB (26%)
chunk.course-table.components.js 77.76 KB 77.71 KB -50 bytes (0%)
chunk.degub.components.js 2.61 KB 2.61 KB 0 bytes (0%)
chunk.new-student.drive.component.js 1.46 KB 1.46 KB 0 bytes (0%)
chunk.new-student.import.component.js 19.74 KB 19.74 KB 0 bytes (0%)
chunk.new-student.manual.component.js 62.29 KB 62.29 KB 0 bytes (0%)
chunk.new-student.upload.component.js 33.58 KB 33.58 KB 0 bytes (0%)
chunk.search-sidebar.components.js 69.82 KB 87.81 KB 17.99 KB (26%)
chunk.semester-detail.components.js 2.23 KB 2.23 KB 0 bytes (0%)
chunk.share-student.components.js 29.88 KB 29.88 KB 0 bytes (0%)
chunk.student.components.js 134.35 KB 134.33 KB -15 bytes (0%)
courseData.url 38 bytes 38 bytes 0 bytes (0%)
google04990d0c4887a5cd.html 53 bytes 53 bytes 0 bytes (0%)
index.html 636 bytes 636 bytes 0 bytes (0%)

@hawkrives hawkrives force-pushed the virtual-list branch 2 times, most recently from 1729d2a to 095d426 Compare July 23, 2018 00:47
@hawkrives hawkrives added this to In Progress in Upcoming Jul 23, 2018
@hawkrives hawkrives merged commit fef0676 into master Sep 23, 2018
Upcoming automation moved this from In Progress to Completed Sep 23, 2018
@hawkrives hawkrives deleted the virtual-list branch September 23, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Upcoming
  
Completed
Development

Successfully merging this pull request may close these issues.

None yet

1 participant