New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up some processes in UploadStudentFile #2238

Merged

hawkrives merged 2 commits into master from upload-cleanups

Jul 23, 2018

Owner

hawkrives commented Jul 23, 2018

renames state.students to state.actions, to better describe what it contains (student creation actions, that is)
properly uses setState callbacks to ensure that data is updated in the proper sequence
replaces a long promise chain with an async function

hawkrives and others added 2 commits

July 23, 2018 11:47


          clean up some processes in UploadStudentFile

e57eb5d


          remove lodash; fix syntax errors

03f00d3

hawkrives merged commit b3835dd into master

Owner Author

hawkrives commented Jul 23, 2018

I tested that a student could still be imported and opened, so these changes are good.

hawkrives added this to Completed in Upcoming

hawkrives deleted the upload-cleanups branch

September 22, 2018 06:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment