Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "filter by" and "limit to" search fields in the sidebar #2302

Merged
merged 9 commits into from
Oct 10, 2018

Conversation

hawkrives
Copy link
Owner

@hawkrives hawkrives commented Oct 10, 2018

"filter by" lets you filter down to just a specific group in the list, so if you group by term, you can only see that term; if you group by department, you can only see that department; etc. It's live with respect to your current "group by" option.

"limit to {year}" lets you easily limit the results to a specific year. It's applied first, so if you limit to 2012, you'll only see grouping options for 2012, etc.


Known issues:

  • If you pick a filter and then change the year limit to a year without that filter key, you will get no results. (this no longer sounds like an issue. testing needed.) not actually the problem; see below
  • if you filter by something, then change the grouping, it still tries to filter by the old key, which no longer applies to the new groups. (fixed by resetting filterBy when we change groupBy)

so that the list comes out with the right times right away
"filter by" lets you filter down to just a specific group in the list,
so if you group by term, you can only see that term; if you group by
department, you can only see that department; etc

"limit to {year}" lets you easily limit the results to a specific year
@hawkrives hawkrives merged commit 3e4f535 into master Oct 10, 2018
@hawkrives hawkrives deleted the filter-search-sidebar branch October 11, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants