Packages

[hawkrives]

This (probably) supersedes #859.

[hawkrives]

KNOWN OLD BUGS (aka bugs not introduced by this PR):

• modules/web/routes/create/routes/manual/manual.js:115: calls dispatch with not-an-action.

  - this.props.dispatch(this.props.router.push(`/s/${action.payload.id}`))
  + this.props.router.push(`/s/${action.payload.id}`)

• Studio Art major: https://github.com/hawkrives/gobbldygook-area-data/blob/master/majors/studio-art.yaml#L64

  • passes as "success" even with no valid courses

• Warning: Unknown prop 'minWidth' on <input> tag. Remove this prop from the element.

  • Known issue: Removes minWidth from props passed to input element. Fixes #53 JedWatson/react-input-autosize#57
  • Not actually an issue, just annoying.

• I had to fix the test suite. It was … not testing the students reducer.

[hawkrives]

+10,999 lines
-882 lines

Hmm. I wonder what files I accidentally included?

[coveralls]

Coverage increased (+0.6%) to 74.024% when pulling aa0d0a0 on packages into 5a68e85 on master.

[hawkrives]

git says, 1224 files changed, 940 insertions(+), 956 deletions(-), which sounds much more in line with what I'd expect.

[coveralls]

Coverage increased (+0.6%) to 74.024% when pulling 4ee65b1 on packages into 5a68e85 on master.

[hawkrives]

Whoo!