New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small Castle Rooms #2046
Small Castle Rooms #2046
Conversation
@8bitgentleman Whats the change in town.tmx? The arrows above the new doors need to be updated to the red arrow that was introduced in #2032 and the rooms seem to be a little small for the screen, they might need to be a little larger. Other than those things mentioned this is pretty cool and will hopefully displays that castle hawkthorne won't always be a long walk. btw I love the key shards it's an awesome use for crafting. |
@CalebJohn Is that what you meant by change the arrow color? I checked and don't think anything changed with town.tmx how do I exclude that from the pull request? I like the idea of key crafting but I'm not sure if we should include it yet. I don't want to burn that idea on a super simple puzzle :) Leave the crafting until there are some more challenging puzzles behind those door. I'm considering replacing the key shards with regular keys for now. |
Ya the arrows should be red in castle hawkthorne as well though, the rooms look awesome though. I think we should leave the key shards, kinda like a teaser for the puzzle that lies ahead. I'm not sure how you can revert town.tmx, but you could just go in and edit out the changes that it looks like this branch makes. |
What's the difference between the red and green arrows? Do them mean something different? The only thing that changed in town.tmx is the draworder="topdown" that shouldn't effect anything so I don't see why it can't stay. |
@8bitgentleman There isn't a difference in arrows - I just changed them all to red to be consistent rather than switching between the colours within a level. |
@8bitgentleman it's best not to have unrelated changes in a pull, this case it probably doesn't change anything but if it does end up breaking something it makes it hard to track. |
@CalebJohn Is that what you mean about fixing the town.tmx changes? I reverted the file back to what it was before. |
@8bitgentleman Ya that's perfect, this is good to merge! |
Loving the key shards! I've got a couple of suggestions:
|
@edisonout Originally, I had this idea that the red arrow means that the door was closed, and once you collect all the keys or something it would turn green, meaning you can walk in, but in hindsight that idea seems dumb now I don't even know why I included it. On another note, even though I didn't check out the level yet, @8bitgentleman I'm sure it's great I can tell by the awesome key shard sprite, these new levels have me pumped. I promise I'll come back once TPP is over hopefully |
Tpp will never end! |
LGTM. |
LGTM |
@didory123 that idea is not a bad one |
@NimbusBP1729 sometimes even I spit out something useful once in a while |
As per CalebJohn's suggestion
http://www.reddit.com/r/hawkthorne/comments/2064in/costumes_made_easy_other_hawkthorne_updates/cg09g3s
Here's a quick and simple addition to Castle Hawkthorne. This add barebones rooms behind the doors and a series of keys and key shards needed to unlock the throne room.