Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API update #28

Merged
merged 13 commits into from
Jul 13, 2015
Merged

API update #28

merged 13 commits into from
Jul 13, 2015

Conversation

arturdryomov
Copy link
Contributor

Mostly a long awaited update for the Hawkular 1.0.0 α 2. As a bonus, the application supports authorization without port set, mostly to handle demo.hawkular.org properly. Yep, it is the default one at this point.

@arturdryomov
Copy link
Contributor Author

CC @pilhuhn @danielpassos

public static final int MINIMUM = 0;
public static final int MAXIMUM = 0xFFFF;

public static boolean isCorrect(@IntRange(from = Ports.MINIMUM, to = Ports.MAXIMUM) int port) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally wonder if we should support non-numeric ports like "https" or "http" instead 443 and 80 - as they show up in /etc/services. But then, the current xml definition only allows numbers, so we should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants