API update #28
Merged
API update #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can have string values for availability condition at this point.
Merged
| public static final int MINIMUM = 0; | ||
| public static final int MAXIMUM = 0xFFFF; | ||
|
|
||
| public static boolean isCorrect(@IntRange(from = Ports.MINIMUM, to = Ports.MAXIMUM) int port) { |
There was a problem hiding this comment.
I generally wonder if we should support non-numeric ports like "https" or "http" instead 443 and 80 - as they show up in /etc/services. But then, the current xml definition only allows numbers, so we should be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a long awaited update for the Hawkular 1.0.0 α 2. As a bonus, the application supports authorization without port set, mostly to handle
demo.hawkular.orgproperly. Yep, it is the default one at this point.