Skip to content

Commit

Permalink
static imports
Browse files Browse the repository at this point in the history
  • Loading branch information
@jmazzitelli
jmazzitelli committed Mar 19, 2015
1 parent 55f700d commit b447ed2
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions ide-configs/eclipse/hawkular-eclipse-preferences-java-codestyle-organizeimports.importorder
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
#Organize Import Order
#Fri Jan 16 11:30:31 EST 2015
3=com
2=org
1=javax
0=java
#Organize Import Order
#Wed Mar 18 17:17:04 EDT 2015
9=
8=com
7=org
6=javax
5=java
4=\#
3=\#com
2=\#org
1=\#javax
0=\#java

5 comments on commit b447ed2

@tsegismont
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmazzitelli from what I understand, static imports should follow the same order as usual imports, right? By the way, should imports categories be separated by blank lines? I'm asking because @lucasponce maintains an IJ settings file and this might be of interest.

@jmazzitelli
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think they should follow the same alphabetic order as usual imports, yes.

As for separating by blank lines, I don't think eclipse actually has a control setting for that - at least, I've never see it. I think Eclipse always puts a blank line between categories of imports - there is no way to tell it otherwise (unless there is a setting somewhere I don't know of).

@jmazzitelli
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, static imports are now configured to go at the top, above normal imports. so right now this eclipse file configures is to be:

static java.*
static javax.*
static org.*
static com.*
static * (all other unmatched imports)
java .*
javax .*
org .*
com .*

  • (all other unmatched imports)

@lucasponce
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sent an update in the settings.jar for IntelliJ with the same imports structure.
Please let me know, or feel free to add an update with the settings.jar.

By the way, we have some statcis imports code and I have always I see them on the bottom not on the top, so probably we can have some commits with just those changes.

@tsegismont
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review PR #14

Please sign in to comment.