-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an avail get_data test. #158
Conversation
Rubocop strikes again! |
3ea4558
to
21c7217
Compare
2 similar comments
Travis is complaining about the cassette metrics_services/Templates/Mixed_metrics/Should_requests_raw_data_for_multiple_metrics.yml I'm not really sure if we should keep metrics_0_0_16 and metrics_services. |
I think at this point we can remove metrics_0_0_16 and leave only metric_services. This was for the testing of transition from old versions of metrics to metrics 0.0.16 (mostly endpoint changes). but because now metric_services test against recent versions of metrics, this doesn't make sense anymore. |
I think it is ok to treat metrics016 and -services as the same. |
I'll fix that and post a PR soon. |
@@ -135,6 +135,7 @@ | |||
id1 = SecureRandom.uuid | |||
id2 = SecureRandom.uuid | |||
id3 = SecureRandom.uuid | |||
id4 = SecureRandom.uuid | |||
|
|||
ids = [id1, id2, id3] | |||
bindings = { id1: id1, id2: id2, id3: id3 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add id4 to this hash (bindings
)?
It will help VCR do its replace-template-magic-thing.
21c7217
to
b84299b
Compare
@josejulio, This dumb PR is finally green :) Please make it go away unless you see something else that needs to be fixed. Thanks, Jay |
Thank you! |
It just tests an extra code path that we didn't have.
@pilhuhn please review.