Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in get() and co + property based tests #88

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Fix bugs in get() and co + property based tests #88

merged 5 commits into from
Oct 4, 2023

Commits on Oct 3, 2023

  1. style: satisfy clippy 

    Fixes several clippy's lints:
* non_canonical_clone_impl
* needless_borrow
    @loyd
    loyd committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    623c0c9 View commit details
    Browse the repository at this point in the history

  2. fix: index out of bounds in get() and get_owned() 

    Prevents public methods from panicking if received keys that haven't been
produced by the slab.
    @loyd
    loyd committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    3dc7c13 View commit details
    Browse the repository at this point in the history

  3. fix(unique_iter): prevent panics if a slab is empty 

    Fixes panics in `Slab::unique_iter()` in case of an empty slab.

Fixes hawkw#73
    @loyd
    loyd committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    f5749ce View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. test: property-based tests to check public API 

    Adds property-based tests that check the following properties:
* API never panics.
* Active entries cannot be overridden until removed.
* The slab doesn't produce overlapping keys.
* The slab doesn't leave "lost" keys.
* `get()`, `get_owned`, and `contains()` are consistent.
* `RESERVED_BITS` are actually not used.
    @loyd
    loyd committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    fdd6be0 View commit details
    Browse the repository at this point in the history

  2. fix(ci): move msrv check to a dedicated job 

    * Add `msrv` job
* Add `RUST_BACKTRACE=1`
* Add `-Dwarnings`
* Fix clippy warnings in benches
* Make job naming more consistent
    @loyd
    loyd committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    14f5826 View commit details
    Browse the repository at this point in the history