Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): expose loaded plugins #46

Merged
merged 1 commit into from Sep 24, 2021

Conversation

brusdev
Copy link
Contributor

@brusdev brusdev commented Sep 22, 2021

The loaded plugins include the context path required to get plugin resources, i.e. AcriveMQ Artemis clould use the loaded plugins to avoid reloading them: apache/activemq-artemis#3765

The loaded plugins include the context path required to get plugin resources.
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I still don't get why we need this. The PluginServlet and PluginRegistry in hawtio/hawtio are what we provide for users and other plugins.

@brusdev
Copy link
Contributor Author

brusdev commented Sep 22, 2021

@tadayosi indeed the current ActiveMQ Artemis branding plugin use PluginServlet to get the plugin list, see https://github.com/apache/activemq-artemis/blob/main/artemis-hawtio/activemq-branding/src/main/webapp/plugin/js/brandingPlugin.js#L37

When a user accesses the console the PluginServlet is requested twice the first time from hawtio PluginLoader and the second time from ActiveMQ Artemis branding plugin.

This change is just to avoid the second request of PluginServlet from ActiveMQ Artemis branding plugin and reuse the outcome of the first request of PluginServlet from hawtio PluginLoader.

@tadayosi
Copy link
Member

@brusdev Thanks. It makes sense. It shouldn't be harmful to have the plugins loaded from hawtioPluginLoader accessible from outside.

@tadayosi tadayosi merged commit b33eb0b into hawtio:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants