feat: added preferences to toggle on/off sidebar #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Feb 22, 2022
tadayosi
requested changes
Feb 22, 2022
src/app/page/page.component.ts
Outdated
| @@ -24,7 +24,12 @@ namespace Page { | |||
| this.previousWidth = this.$window.innerWidth; | |||
| }); | |||
| }); | |||
| this.$rootScope.$on(CLOSE_MAIN_NAV_EVENT, () => this.isNavOpen = false); | |||
| var curr_state = window.localStorage.getItem('current_state'); | |||
| if (curr_state === "ON") | |||
There was a problem hiding this comment.
Always use { and } for if. I don't think we omit these in other places.
There was a problem hiding this comment.
If we use Enum for the values it can be switch statement.
src/app/preferences/general-preferences/general-preferences.controller.ts
Show resolved
Hide resolved
src/app/preferences/general-preferences/general-preferences.html
Outdated
Show resolved
Hide resolved
src/app/preferences/general-preferences/general-preferences.module.ts
Outdated
Show resolved
Hide resolved
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
|
I have incorporated all the requested changes in the commit aa344f9. Please check it and provide further feedback :) |
tadayosi
requested changes
Feb 22, 2022
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
| return this.$window.localStorage.getItem('defaultVerticalNavState'); | ||
|
|
||
| } | ||
| setDefaultVerticalnavstate(defaultVerticalNavState): void { |
There was a problem hiding this comment.
and what about using enum for the state variable?
src/app/preferences/general-preferences/general-preferences.module.ts
Outdated
Show resolved
Hide resolved
src/app/page/page.component.ts
Outdated
| @@ -24,7 +24,14 @@ namespace Page { | |||
| this.previousWidth = this.$window.innerWidth; | |||
| }); | |||
| }); | |||
| this.$rootScope.$on(CLOSE_MAIN_NAV_EVENT, () => this.isNavOpen = false); | |||
| let curr_state = window.localStorage.getItem('defaultVerticalNavState'); | |||
| if (curr_state === "show") { | |||
There was a problem hiding this comment.
and regarding where the VerticalNavState enum type should be defined, there are a few options. But I think the simplest is just put it in the page.component.ts and then from the general-preferences.service.ts reference it.
|
And I'd prefer the commits to be only one. Please force push to the pr branch instead of adding a commit on top of the original. |
prahaladhchandrahasan
force-pushed
the
issue-#2657-vertical-nav-preference
branch
3 times, most recently
from
28e8b44
to
3ae6952
Compare
tadayosi
requested changes
Feb 24, 2022
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
tadayosi
requested changes
Feb 24, 2022
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
prahaladhchandrahasan
force-pushed
the
issue-#2657-vertical-nav-preference
branch
from
2308b66
to
70b4697
Compare
tadayosi
requested changes
Feb 24, 2022
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
src/app/preferences/general-preferences/general-preferences.service.ts
Outdated
Show resolved
Hide resolved
tadayosi
reviewed
Feb 24, 2022
prahaladhchandrahasan
force-pushed
the
issue-#2657-vertical-nav-preference
branch
from
fb5f2e0
to
c8baaff
Compare
tadayosi
reviewed
Feb 24, 2022
| getDefaultVerticalNavState(): string { | ||
| if (this.$window.localStorage.getItem('defaultVerticalNavState') !== null) { | ||
| return this.$window.localStorage.getItem('defaultVerticalNavState'); | ||
| } else |
There was a problem hiding this comment.
One more last change:
} else {
...
}
119940f
to
cc56ec0
Compare
prahaladhchandrahasan
deleted the
issue-#2657-vertical-nav-preference
branch
prahaladhchandrahasan
restored the
issue-#2657-vertical-nav-preference
branch
prahaladhchandrahasan
deleted the
issue-#2657-vertical-nav-preference
branch
This was referenced Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a feature which solves the issue:
Issue link: hawtio/hawtio#2657