Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This warning seems to be a common occurence during building.... #474

Closed
phantomjinx opened this issue Jul 28, 2023 · 2 comments · Fixed by #480
Closed

This warning seems to be a common occurence during building.... #474

phantomjinx opened this issue Jul 28, 2023 · 2 comments · Fixed by #480
Labels
area/build kind/enhancement Enhancements that don't necessarily result in a new feature
Milestone

Comments

@phantomjinx
Copy link
Member

Warning: ▲ [WARNING] "tsconfig.json" does not affect esbuild's own target setting [tsconfig.json]
[hawtio] 
[hawtio]     tsconfig.json:7:4:
[hawtio]       7 │     "target": "es2015",
[hawtio]         ╵     ~~~~~~~~
[hawtio] 
[hawtio]   This is because esbuild supports reading from multiple "tsconfig.json" files within a single build, and using different language targets for different files in the same build wouldn't be correct. If you want to set esbuild's language target, you should use esbuild's own global "target" setting such as with "target: 'es2015'".
[hawtio] 

Is this something of concern or should it just be ignored?

@tadayosi
Copy link
Member

It has popped up after upgrading tsup. It should be related to some changes in esbuild/tsup. Ideally we should resolve the warning but simply removing the target entry from tsconfig.json doesn't seem to fix it. So far I don't see any harms in the warning.

@tadayosi tadayosi added the kind/enhancement Enhancements that don't necessarily result in a new feature label Jul 31, 2023
@tadayosi
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build kind/enhancement Enhancements that don't necessarily result in a new feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants