Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jbang): support red hat maven repositories for jbang #3186

Merged
merged 1 commit into from Jan 23, 2024

Conversation

tadayosi
Copy link
Member

This should enable users to run a Hawtio version provided on MRRC as follows:

jbang -Dhawtio.jbang.version=4.0.0.redhat-00029 hawtio@hawtio/hawtio

@Croway Please review this to check if I'm doing it correctly.

Copy link

Test Results

  4 files  ±0    4 suites  ±0   12m 9s ⏱️ -4s
 59 tests ±0   59 ✅ ±0  0 💤 ±0  0 ❌ ±0 
234 runs  ±0  234 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 03a1cca. ± Comparison against base commit 6b6ef13.

@hawtio-ci
Copy link

hawtio-ci bot commented Jan 23, 2024

Test results

Run attempt: 1028
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-17-firefox 59 59 0 0 0 178.956
results-quarkus-21-firefox 59 59 0 0 0 179.217
results-springboot-17-firefox 58 58 0 0 0 186.024
results-springboot-21-firefox 58 58 0 0 0 184.986

@Croway
Copy link
Contributor

Croway commented Jan 23, 2024

Hi @tadayosi , jbang -Dhawtio.jbang.version=4.0.0.redhat-00029 hawtio@hawtio/hawtio this should work as expected, but the productized version cannot be (easily) installed via jbang app install ... do you think the app install use case should be handled too?

@tadayosi
Copy link
Member Author

@Croway Thanks, you're right. So I asked JBang team and it appears jbang app install doesn't support such a use case yet: jbangdev/jbang#1736

So right now, what we could do are either using alias instead of jbang app install:

$ alias hawtio='jbang -Dhawtio.jbang.version=4.0.0.redhat-00029 hawtio@hawtio/hawtio'

or doing jbang app install but post-editing the installed script:

$ jbang app install hawtio@hawtio/hawtio
$ vi .jbang/bin/hawtio
#!/bin/sh
exec jbang run -Dhawtio.jbang.version=4.0.0.redhat-00029 hawtio@hawtio/hawtio "$@"

@tadayosi tadayosi merged commit 12f949d into hawtio:4.x Jan 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants