Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x improvements #3235

Merged
merged 3 commits into from Feb 22, 2024
Merged

4.x improvements #3235

merged 3 commits into from Feb 22, 2024

Conversation

grgrzybek
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited

Test Results

  4 files  ±0    4 suites  ±0   12m 25s ⏱️ -7s
 60 tests ±0   59 ✅ ±0   1 💤 ±0  0 ❌ ±0 
244 runs  ±0  234 ✅ ±0  10 💤 ±0  0 ❌ ±0 

Results for commit 1c2de05. ± Comparison against base commit d8002a8.

♻️ This comment has been updated with latest results.

@hawtio-ci
Copy link

hawtio-ci bot commented Feb 20, 2024 •
edited

Test results

Run attempt: 1154
Detailed summary

NAME TESTS PASSED ✅ SKIPPED 💤 FAILED ❌ ERRORS 🚫 TIME 🕖
results-quarkus-17-firefox 61 59 2 0 0 183.388
results-quarkus-21-firefox 61 59 2 0 0 185.142
results-springboot-17-firefox 61 58 3 0 0 185.623
results-springboot-21-firefox 61 58 3 0 0 190.862

tadayosi
tadayosi approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'd like to know the context of the changes. What are they supposed to be used for?

hawtio-system/src/main/java/io/hawt/util/Strings.java Outdated Show resolved Hide resolved
hawtio-system/src/test/java/io/hawt/util/StringsTest.java Show resolved Hide resolved
hawtio-system/src/test/java/io/hawt/util/StringsTest.java Show resolved Hide resolved
hawtio-system/src/test/java/io/hawt/util/StringsTest.java Show resolved Hide resolved
tests/hawtio-test-suite/pom.xml Show resolved Hide resolved
@grgrzybek
Copy link
Contributor Author

LGTM.

I'd like to know the context of the changes. What are they supposed to be used for?

new Strings method will be used by OIDC part to load keystores/truststores for server-side http-client connections made (on initialization and cache invalidation) by OidcLoginModule to JWKS endpoint (to fetch public keys). I'd like to have everything configurable in single properties file where property values can have placeholders.

@tadayosi tadayosi merged commit f4fd7f7 into 4.x Feb 22, 2024
10 checks passed
@tadayosi tadayosi deleted the 4.x-improvements branch April 5, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadayosi tadayosi tadayosi approved these changes

@oscerd oscerd oscerd approved these changes

@mmelko mmelko Awaiting requested review from mmelko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grgrzybek @tadayosi @oscerd