Add account lockout test #3406
Add account lockout test #3406
Conversation
Test resultsRun attempt: 1568
|
| String pass = "gojo"; | ||
| int maxRetries = 7; | ||
| int retries = 0; | ||
| while (!warning.isDisplayed() && retries < maxRetries) { | ||
| Selenide.Wait().until(ExpectedConditions.visibilityOf(loginButton)); | ||
| loginInput.shouldBe(editable).setValue(username); | ||
| passwordInput.shouldBe(editable).setValue(pass); | ||
| loginButton.shouldBe(enabled).click(); | ||
| retries++; | ||
| } | ||
|
|
||
|
|
||
| Selenide.Wait().until(ExpectedConditions.visibilityOf(loginButton)); |
There was a problem hiding this comment.
Please create another method to test the throttling behavior and create a Cucumber scenario for it.
We should be testing that the throttling time is increasing (2 or 3 attempts is enough).
|
|
||
| public class ThrottlingStepDefs { | ||
| private final LoginPage loginPage = new LoginPage(); | ||
| private final static SelenideElement warning = $("p.pf-c-form__helper-text.pf-m-error"); |
There was a problem hiding this comment.
It's preferable for this to be just By with the selector and you call the selenide function $ when you need to access the element. This is because sometimes the elements on the webpage can change and leads to Selenide throwing an exception that the reference to the element is stale, it's rare but annoying 😸
Also it's best practice to name constants in ALL_UPPERCASE, in this case warning is a constant.
| @Then("the user should see a message indicating account lockout second time") | ||
| public void theUserShouldSeeAMessageIndicatingAccountLockoutSecondTime() { | ||
| warning.shouldHave(text("Login attempt blocked. Retry after 3 seconds")); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please make this a universal step "the user should see a message indicating account lockout for {int} seconds" and format the text condition to contain the int parameter.
kariuwu
force-pushed
the
kariuwu-authen
branch
2 times, most recently
from
c616efd
to
8d24375
Compare
| @When("the user attempts to log in with incorrect credentials {int} times") | ||
| public void theUserAttemptsToLogInWithIncorrectCredentialsTimes(int attempts) { | ||
| for (int i = 0; i < attempts; i++) { | ||
| loginPage.throttling("username", "invalid"); | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
The same step is on line 37, the only difference is just credentials -> credential, one can be removed
| @@ -0,0 +1,8 @@ | |||
| Feature: Account Lockout (Throttling) | |||
There was a problem hiding this comment.
I would but the throttling.feature file in some other folder. This implies there will be more throttling feature files to come which it hopefully wont. What about security/auth folder?
No description provided.