Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JSDoc and fix tab size and alignment #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ExE-Boss
Copy link

@ExE-Boss ExE-Boss commented Aug 8, 2017

Because these two fixes are so closely connected to one another, I am submitting them as part of the same PR.


Split off from #2

This PR fixes this list of issues I found in the script:

  • Fixes broken tab size:
    This is done by using the ch unit instead of the em unit
  • Fixes broken tab alignment:
    This is done by ensuring that the wrapAllTabs() function doesn't try to wrap a tab multiple times.
  • Doesn't work license headers and code documentation, which are written like so:
    /**
     * The following object does stuff
     * @type Object
     */
    var obj = {
    	longValueName:	"This string is long",
    	foo:	"foo",
    	bar:	"bar",
    	getBaz	= function getBaz()
    	{
    		return bar;
    	}
    }
    This should render as:
    /**
     * The following object does stuff
     * @type Object
     */
    var obj = {
            longValueName: "This string is long",
            foo:           "foo",
            bar:           "bar",
            getBaz         = function getBaz()
            {
                    return bar;
            }
    }
    But because of the does line start with a space check in index.js#41, this doesn't happen, because the second line of this file turns elastic tabstops off.

@ExE-Boss ExE-Boss changed the title This adds support for JSDoc and also fixes tab size and alignment Add support for JSDoc and fix tab size and alignment Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant